Re: [libvirt] [PATCH 19/21] tests: qemuxml2argv: move DO_TEST qemuCaps init
On Thu, 2019-03-14 at 10:44 -0400, Cole Robinson wrote:
[...]
+ if (gic && testQemuCapsSetGIC(info->qemuCaps, gic)
< 0)
+ goto cleanup;
Please change the first part of the condition to 'gic != GIC_NONE'
so that it doesn't implicitly rely on the actual value.
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization