Re: [libvirt] xenUnifiedDomainLookupByName error handling
On Wed, Jan 14, 2009 at 08:03:49PM +0000, John Levon wrote:
We do:
700 /* Not found. */
701 xenUnifiedError (conn, VIR_ERR_NO_DOMAIN, __FUNCTION__);
But:
# virsh start domu-defefe
12:09:30.581: error : Domain not found: xenUnifiedDomainLookupByName
libvir: Xen error : Domain not found: xenUnifiedDomainLookupByName
libvir: Xen error : Domain not found: xenUnifiedDomainLookupByName
error: failed to get domain 'domu-defefe'
It doesn't seem right to be reporting errors like this. What's the
intent? Most of xenUnifiedError() seems to be internal errors, but many
of them are just clients doing the wrong thing...
In the virsh case, it really should be just registering a callack to
disable the default fprintf() of errors, since it always prints its
own error message in a more use friendly format. We've done this in
virt-install already for the same reason.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|