1 Aug
2017
1 Aug
'17
10:44 p.m.
On 07/26/2017 09:29 AM, Ján Tomko wrote:
This function returns false if virDomainDeviceInfoFormat would not format anything.
Using it as the sole condition to decide whether to call virDomainDeviceInfoFormat or not is pointless, since the conditions are repeated in virDomainDeviceInfoFormat. --- src/conf/domain_conf.c | 33 +++++++++++---------------------- 1 file changed, 11 insertions(+), 22 deletions(-)
Reviewed-by: John Ferlan <jferlan@redhat.com> John FWIW: minor nit... In virDomainDeviceInfoFormat, there's an "info->rombar ||" condition that could be "info->rombar != VIR_TRISTATE_SWITCH_ABSENT ||"