Thanks for reviewing this patch. On Fri, Aug 01, 2008 at 10:02:50AM +0200, Jim Meyering wrote:
What if either contains shell meta-characters? To accommodate you'd have to shell-quote as needed, or (as I prefer) simply detect the bogosity and refuse to run the command.
Yes, not quite sure what I was thinking of there. The new version should reject characters in both the editor & filename which are not in a small recognized set of characters.
You can mark entries as "const": static const vshCmdOptDef opts_edit[] = {
This gives an error because the vshCmdDef array where we aggregate all of these doesn't expect the const pointer. Obviously it's a general const-correctness problem which needs a separate patch to fix throughout the whole file. A new patch is attached which should address everything that you mentioned. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v