Re: [libvirt] [PATCH] build: shut up automake warnings

On Wed 04 Sep 2013 06:48:46 PM CEST, Eric Blake wrote: > I'm tired of seeing screenfuls of messages like these when using > automake 1.13 (Fedora 19): > > configure.ac:2121: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged. > configure.ac:2121: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead, > configure.ac:2121: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files. > daemon/Makefile.am:19: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') > These were driving me crazy, but I thought we had no other option than to leave this due to compatibility. Thanks for finding the way out of this. Unfortunately, 1.14 complains about subdir-objects way more than about anything else and I still haven't found the way out of that one.

> -# Use the silent-rules feature when possible. > -m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])]) > -AM_SILENT_RULES([yes]) > +# Default to using the silent-rules feature when possible. Formatting > +# chosen to bypass 'grep' checks that cause older automake to warn. > +# Users (include rpm) can still change the default at configure time. > +m4_ifndef([AM_SILENT_RULES], > + [m4_define([AM_SILENT_RULES],[])])AM_SILENT_RULES([yes]) > Funny that only simple grep is used to identify these.

ACK,