Re: [libvirt] [PATCH v3] qemuhotplugtest: Add tests for ccw devices
On Fri, Jul 22, 2016 at 08:10:47PM +0200, Tomasz Flendrich wrote:
There's a plan to rework the address handling, so testcases
that verify hotplugging ccw devices will help in avoiding
regression.
In this commit, some files are duplicated because of the way
qemuhotplug.c calculates the expected xml filenames.
I plan on changing that to explicitly stating the basis domain
xml, the device xml, and the expected xml.
---
Changes in v3:
* incorrect vde2 is removed in another .xml file, so that there are
duplicates of aliases
Thanks for redoing this. ACK && will push this in a while.
However the previous version is something that could be tested in the
future as that should always fail (we just couldn't see it because it
would fail in QEMU which is what we should not let happen).
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)