On 10/06/2012 01:20 PM, Doug Goldstein wrote:
Add a read-only udev based backend for virInterface. Useful for
distros
that do not have netcf support yet. Multiple libvirt based utilities use
a HAL based fallback when virInterface is not available which is less
than ideal. This implements:
* virConnectNumOfInterfaces()
* virConnectListInterfaces()
* virConnectNumOfDefinedInterfaces()
* virConnectListDefinedInterfaces()
* virConnectListAllInterfaces()
* virConnectInterfaceLookupByName()
* virConnectInterfaceLookupByMACString()
---
Change from v5:
* squash the virConnectListAllInterfaces() patch in
* rename status enum to virUdevStatus
* remove checks that don't print errors as the value is checked elsewhere
* provide helpers for NumOfInterfaces/NumOfDefinedInterfaces to reduce code
* provide helpers for ListInterfaces/ListDefinedInterfaces to reduce code
Looks good; the remaining things I asked in v5 you have saved for later
in the series.
ACK and pushed, with a couple of tweaks.
+ /* List all interfaces incase we support more filter flags in
the future */
s/incase/in case/
Also, I squashed in a line from patch 3/5.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org