On Thu, Aug 08, 2024 at 09:29:41 +0200, Peter Krempa wrote:
On Wed, Aug 07, 2024 at 15:59:52 +0100, Daniel P. Berrangé wrote:
[...]
diff --git a/tests/qemuxmlconfdata/broken-xml-invalid.x86_64-latest.err b/tests/qemuxmlconfdata/broken-xml-invalid.x86_64-latest.err index 601f547cc6..77fe29cff0 100644 --- a/tests/qemuxmlconfdata/broken-xml-invalid.x86_64-latest.err +++ b/tests/qemuxmlconfdata/broken-xml-invalid.x86_64-latest.err @@ -1,3 +1,3 @@ -/home/pipo/libvirt/tests/qemuxmlconfdata/broken-xml-invalid.xml:2: Couldn't find end of Start Tag dom line 1 +(domain_definition):2: Couldn't find end of Start Tag dom line 1 (null) ^
This is in turn a significant regression in error message quality as it no longer references the filename.
Forgot to add that the '(domain_definition)' is an arbitrary string that libvirt passes to libxml so unless libxml would try to interpret it somehow it should be an easy fix.