Re: [libvirt] [PATCH 07/11] Introduce portability APIs for creating threads

2010/11/8 Daniel P. Berrange <berrange(a)redhat.com&gt;: > The util/threads.c/h code already has APIs for mutexes, > condition variables and thread locals. This commit adds > in code for actually creating threads. > > * src/libvirt_private.syms: Export new symbols > * src/util/threads.h: Define APIs virThreadCreate, virThreadSelf, >  virThreadIsSelf and virThreadJoin > * src/util/threads-win32.c, src/util/threads-win32.h: Win32 >  impl of threads > * src/util/threads-pthread.c, src/util/threads-pthread.h: POSIX >  impl of threads >  struct virThreadLocalData { > @@ -33,7 +35,7 @@ typedef virThreadLocalData *virThreadLocalDataPtr; >  virMutex virThreadLocalLock; >  unsigned int virThreadLocalCount = 0; >  virThreadLocalDataPtr virThreadLocalList = NULL; > - > +DWORD selfkey; > >  virThreadLocal virCondEvent; Not introduced by this patch, but why are this local variables not marked as static?