Re: [libvirt] [PATCH 07/10] network: new XML to support virtual switch functionality

> > It turns out that we've used internal-use flags before. See how > libvirt.c filters out flags in both virDomainGetXMLDesc and > virSecretGetValue if the flags are larger than 0xffff, so that it can > start internal flags at 1<<16. Regarding the networking code and our > discussions on whether we should split out a second internalFlags > argument rather than cramming internal and external flags into a single > parameter, I think we should be consistent. The difference is that this was an internal impl detail not exposed in the public headers, so could be removed at any time. > Meanwhile, I've got a patch to libvirt.c; I think virDomainGetXMLDesc > should reject an attempt to pass 1<<16, rather than silently ignore it. No, that would not be a good idea, because libvirt.c is in the code path for the remote client, as well as the server side.

We don't want todo any flag filtering on the remote client side at all, since we can't expect the client & server to be on the same versions. Flag filtering can only be done after dispatch via the internal driver table, eg in QEMU, LXC, etc directly.