Re: [libvirt] [libvirt-glib 1/6] Getters for GVirConfigDomainInterface attributes

Ah, I just realized why that is so: static char *libxml_str_to_glib(xmlChar *str) { char *g_str; if (str == NULL) return NULL; g_str = g_strdup((char *)str); xmlFree(str); return g_str; } This function is not needed as all you needed was to cast the 'xmlChar *' to 'const gchar *' and return const from all users of this function. Since we still are not API/ABI stable, I propose we change this all over as there is no need to force apps to free strings all the time and waste processor/memory on all these string allocation/de-allocation.