On Wed, May 21, 2008 at 10:21:09PM +0100, Daniel P. Berrange wrote:
While testing Cole's series of patches I identified a couple more places where we leak memory.
In libvirt.c, the default authentication callback uses uninitialized data, and indeed strdup()'s it and this is then never released. This simply disables that bit of code.
In qparams.c when free'ing the struct the 'p' struct field was not released. I took the opportunity to switch it over to using the new style memory.h functions
In remote.c there were a couple of handlers which forgot to free the virDomainPtr object when they were done.
Sure, +1. Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/