FWIW: No need for stop (e.g. '.') at end of each comment message... On 2/18/19 2:09 PM, Julio Faracco wrote:
The new method called lxcNetworkParseDataIPs() is responsible to handle IPv{4,6} settings now. The idea is let lxcNetworkWalkCallback() method handle all entries related to network definition only.
Signed-off-by: Julio Faracco <jcfaracco@gmail.com> --- src/lxc/lxc_native.c | 65 +++++++++++++++++++++++++------------------- 1 file changed, 37 insertions(+), 28 deletions(-)
diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index 1eee3fc2bb..5bbbbf132c 100644 --- a/src/lxc/lxc_native.c +++ b/src/lxc/lxc_native.c @@ -552,6 +552,42 @@ lxcAddNetworkDefinition(lxcNetworkParseData *data) return -1; }
+static int +lxcNetworkParseDataIPs(const char *name, virConfValuePtr value, lxcNetworkParseData *parseData)
When adding new functions we like to see 2 blank lines before/after each method and each argument for the method on it's own line. I've fixed all of this for you... Reviewed-by: John Ferlan <jferlan@redhat.com> John [...]