Re: [libvirt] [PATCH] relaxng: allow : in /dev/disk/by-path names

On Thu, Mar 26, 2015 at 16:58:46 -0600, Eric Blake wrote: > On IRC, Hydrar pointed a problem where 'virsh edit' failed on > his domain created through an ISCSI pool managed by virt-manager, > all because the XML included a block device with colons in the > name. > > * docs/schemas/basictypes.rng (absFilePath): Add colon as safe. > * tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.xml: New file. > * tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.args: Likewise. > * tests/qemuxml2argvtest.c (mymain): Test it. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > docs/schemas/basictypes.rng | 2 +- > .../qemuxml2argvdata/qemuxml2argv-disk-iscsi.args | 7 ++++++ > tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.xml | 28 ++++++++++++++++++++++ > tests/qemuxml2argvtest.c | 1 + > 4 files changed, 37 insertions(+), 1 deletion(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.xml Hmm, I'm lucky I don't change XMLs of my iSCSI-backed domains. Otherwise I would have been beaten by this bug too. ACK