On 11/28/13 09:27, Osier Yang wrote:
On 27/11/13 23:14, Peter Krempa wrote:
To support testing of "volume" disk backing, we need to implement a few disk driver backend functions.
The fake storage driver uses files in storagepoolxml2xmlout/POOLNAME.xml as XML files for pool definitions and volume names are in format "VOL_TYPE+VOL_PATH". By default type "block" is assumed (for iSCSI test compatibility).
The choice of this approach along with implemented functions was made so that <disk type='volume'> can be tested in the xml2argv test. --- tests/qemuxml2argvtest.c | 183 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 183 insertions(+)
...
Others look fine. ACK if you fix those comments.
I've fixed the comments and pushed this patch. Thanks. Peter