On Wed, Feb 27, 2019 at 12:31:56PM -0500, John Ferlan wrote:
ping?
I also think that w/ Peter's addition of VIR_XPATH_NODE_AUTORESTORE even more changes could be done, but I'd leave those for either Peter to finish what he started or the mythical future someone else.
I also found some occurrences of virObjectUnref which may be replaced by VIR_AUTOUNREF, so if you wouldn't mind posting a follow up so that we don't need to revisit this module for the same purpose for a while. A few more notes for a potential follow-up: - in virDomainKeyWrapDefParseXML we could introduce a VIR_AUTOFREE helper for keywrap and do VIR_STEALPTR so that we can get rid of the whole cleanup section - virDomainVsockDefNew could make use of VIR_AUTOPTR - virDomainDefBootOrderPostParse could make use of VIR_AUTOPTR - virDomainDefValidateAliases (VIR_AUTOPTR) - virDomainDeviceValidateAliasImpl (VIR_AUTOPTR) - virDomainDiskSourcePoolDefParse (VIR_AUTOPTR) - virSysinfoChassisParseXML (VIR_AUTOPTR) - virDomainCachetuneDefParse (VIR_AUTOUNREF) - virDomainMemorytuneDefParse (VIR_AUTOUNREF) - virDomainDefAddImplicitVideo (VIR_AUTOPTR) And a bunch of others which I didn't bother checking thoroughly. Erik