Re: [libvirt] [PATCH] esx: Extend VI generator to cover managed object types

On Sun, Apr 10, 2011 at 01:27:56PM +0200, Matthias Bolte wrote: > Generate lookup functions for managed object types. > --- >  src/esx/esx_vi.c               |  414 +++++++++++++++++++++++----------------- >  src/esx/esx_vi.h               |    2 + >  src/esx/esx_vi_generator.input |   28 +++- >  src/esx/esx_vi_generator.py    |  411 ++++++++++++++++++++++++++++++++++++++-- >  src/esx/esx_vi_types.c         |  349 ++++++---------------------------- >  src/esx/esx_vi_types.h         |  102 ++--------- >  6 files changed, 728 insertions(+), 578 deletions(-)  Hum, it's a fairly big patch, and I won't pretend to fully understand it. A cursory look didn't raised any issue to me, and since you're the one managing that code, the best is for you to push it and others to make sure everything still works well, so the earlier the better :-)

 ACK, Daniel