On Thu, Feb 21, 2008 at 02:51:20PM +0000, Richard W.M. Jones wrote:
I'm mostly with Dan Berrange here. Surely an environment variable is the right thing to do, and then later we can add some advanced probing if the environment variable alone doesn't satisfy users.
The only problem I see is making the NULL case unpredictable or introducing unreproducible bugs. But I guess that's not very likely.
I agree - possible, but not likely too bad - I think we'll easily have a net win thanks to a more pleasant default end user experiance.
Dan's patch (http://www.redhat.com/archives/libvir-list/2008-January/msg00234.html) is fine except it should include a DEBUG() statement so we have some chance to gather information from bug reports about what it was actually trying to connect to. At the moment, the first DEBUG() isn't done until after the URI is parsed, and URI parsing is quite likely to be a failure point.
Actually in the PolicyKit fix I committed yesterday, I moved the DEBUG statement into the virConnectOpen() method so we should see the URI printed before any processing is done. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|