Re: [libvirt] [PATCH] network driver: log error and abort network startup when radvd isn't found
On 03/18/2011 12:55 PM, Laine Stump wrote:
>>
>> + if (access(RADVD, X_OK)< 0) {
> Hmm, should this use
>
> if (!virFileIsExecutable(RADVD)) {
>
> instead? Then again, I count 10 instances of 'access.*X_OK', but only 5
> of FileIsExecutable, so maybe it's worth a separate cleanup (and a
> cfg.mk rule to enforce whatever decision we make).
>
Okay. I pushed it using access(RADVD, X_OK). We can consider converting
everything to virFileIsExecutable separately. Thanks!
Agreed that cleanup should be separate, and also, after more thought,
that we should do it. We already had a case in the past where
access("qemu", X_OK) succeeded on a directory named qemu, but you can't
execute that (in fact, that's why virFileIsExecutable was written!).
Since I'm probably the best at writing cfg.mk rules to catch any
remaining access(.*X_OK), it probably falls to me to write the patch :)
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)