On Tue, 2018-09-11 at 16:38 -0600, Jim Fehlig wrote:
[...]
Since Xen 4.6 contains a pkgconfig file, drop the now unused code
that falls back to using LIBVIRT_CHECK_LIB in the absence of
pkgconfig file.
[...]
- dnl pkgconfig file not found, fallback to lib probe
- if test "x$with_libxl" = "xno" ; then
- with_libxl="$old_with_libxl"
-
- dnl LIBXL_API_VERSION 4.4.0 introduced a new parameter to
- dnl libxl_domain_create_restore for specifying restore parameters.
- dnl The libxl driver will make use of this new parameter for specifying
- dnl the Xen migration stream version. Specify LIBXL_API_VERSION to trigger
- dnl an error if there is too old xenlight
- libxlold_CFLAGS="$CFLAGS"
- CFLAGS="$CFLAGS $LIBXL_API_VERSION"
- LIBVIRT_CHECK_LIB([LIBXL], [xenlight], [libxl_ctx_alloc], [libxl.h],
[fail="1"])
- CFLAGS="$libxlold_CFLAGS"
-
- if test $fail = 1; then
- AC_MSG_ERROR([You must install the libxl Library from Xen >= 4.4 to compile
libxenlight driver with -lxl])
- fi
- fi
This broke CI builds:
https://ci.centos.org/view/libvirt/job/libvirt-rpm/
It's not libvirt's fault, but rather an issue with Xen packaging
which I've reported accordingly:
https://bugzilla.redhat.com/show_bug.cgi?id=1629643
Depending on how long it takes to get that fixed in Fedora, we
might want to temporarily reintroduce the fallback path...
--
Andrea Bolognani / Red Hat / Virtualization