Re: [libvirt] [PATCH] virsh: fix regression in argv parsing

On 09/21/2011 08:54 AM, Eric Blake wrote: >Commit 85d2810 broke commands with mandatory argv (send-key, >qemu-monitor-command). This fixes things, and enhances the >test to cover it. To make review easier, I'll enhance the commit message: Prior to commit 85d2810, we had an issue where: snapshot-create-as dom name --diskspec spec --diskspec spec failed to parse the second spec, because the first spec had marked that option as no longer requiring an argument. In commit 85d2810, I fixed it by making argv options no longer mark the option as seen. But this in turn breaks mandatory argv options, which now complain that the argv option is missing. This patch reverts that part of 85d2810, and instead replaces it with fixes to no longer clear opts_need_arg of an argv argument.