Re: [libvirt] [RFC PATCH 00/12] Support multiple PHBs on pSeries guests
On Tue, Feb 28, 2017 at 05:12:32PM +0100, Andrea Bolognani wrote:
Note: if you want to try this out, you'll need to make sure
your QEMU binary includes this commit[1]; moreover,
that commit is missing a way for libvirt to detect
whether the new naming scheme is in place, so this
will have to remain an RFC until the QEMU side has
been sorted out.
[snip]
IMHO changing QEMU naming just for sake of making PPC look slightly
more like non-PPC architecture is not enough justification for making
an incompatible change like this. As you show above, regardless of
whether libvirt currently uses this feature or not, it hurts libvirt
because when we do add support we need to be able to cope with new
and old QEMU. I'd suggest that commit is simply dropped unless there
is a clear functional reason for why the naming must be changed, not
merely a style reason.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|