Re: [libvirt] [PATCHv3 06/43] snapshot: track current snapshot across restarts

On Wed, Aug 24, 2011 at 09:22:23AM -0600, Eric Blake wrote: > Audit all changes to the qemu vm->current_snapshot, and make them > update the saved xml file for both the previous and the new > snapshot, so that there is always at most one snapshot with > <active>1</active> in the xml, and that snapshot is used as the > current snapshot even across libvirtd restarts. > > * src/conf/domain_conf.h (_virDomainSnapshotDef): Alter member > type and name. > * src/conf/domain_conf.c (virDomainSnapshotDefParseString) > (virDomainSnapshotDefFormat): Update clients. > * docs/schemas/domainsnapshot.rng: Tighten rng. > * src/qemu/qemu_driver.c (qemuDomainSnapshotLoad): Reload current > snapshot. > (qemuDomainSnapshotCreateXML, qemuDomainRevertToSnapshot) > (qemuDomainSnapshotDiscard): Track current snapshot. > --- > docs/schemas/domainsnapshot.rng | 5 ++- > src/conf/domain_conf.c | 6 ++- > src/conf/domain_conf.h | 4 +- > src/qemu/qemu_driver.c | 81 +++++++++++++++++++++++++++++---------- > 4 files changed, 72 insertions(+), 24 deletions(-) ACK