Re: [libvirt] [PATCH] virt-xml-validate: Allow input to be read from stdin

21 May 2019


      Hello,

Am 21.05.19 um 09:35 schrieb Johannes Holmberg:
...
On Tue, 2019-05-21 at 07:36 +0200, Philipp Hahn wrote:
...
Am 20.05.19 um 13:57 schrieb Johannes Holmberg:
...
diff --git a/tools/virt-xml-validate.in b/tools/virt-xml-validate.in
...
+if [ "$XMLFILE" = "-" ]; then
+    TMPFILE=`mktemp --tmpdir virt-xml.XXXX`
...
Quoting
Good point(s). I can only imagine I skipped the quoting because TMPFILE
is known to contain a safe string,
No, it's not guaranteed, as it honors TMPDIR:
...
$ LANG=C TMPDIR='/tmp/un safe' mktemp --tmpdir virt-xml.XXXX
mktemp: failed to create file via template '/tmp/un safe/virt-xml.XXXX': ...
Philipp