On Tue, Oct 27, 2015 at 06:10:35PM -0400, John Ferlan wrote:
$SUBJ: Expose virshNodeDeviceList{Collect|Free} and virshNodeDeviceList struct
On 10/27/2015 11:01 AM, Pavel Hrdina wrote:
Next patch will use those function to collect NodeDevice list and find a specific device. Make functions virshNodeDeviceListCollect() and virshNodeDeviceListFree() together with struct virshNodeDeviceList available to reuse existing code.
Exposing virshNodeDeviceListCollect, virshNodeDeviceListFree, and virshNodeDeviceList allows the data returned to be available to other virsh API's that may need them in the future.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- tools/virsh-nodedev.c | 16 +++++----------- tools/virsh-nodedev.h | 11 +++++++++++ 2 files changed, 16 insertions(+), 11 deletions(-)
OK - all that said, but your future patches don't use these functions, so is there really any use for this patch yet? It seems your 2/3 has removed what was in the 3/4 in your prior series related to calling virshNodeDeviceListCollect (and noted in your cover letter as being removed).
I don't oppose the change, but it doesn't seem necessary.
Thanks, I don't know why I didn't remove this patch from series, because it's not required anymore. I'm not pushing this one. Thanks, Pavel