Re: [libvirt] [PATCH v2 1/3] virsh-nodedev: makes struct and functions for NodeDevice list available

$SUBJ: Expose virshNodeDeviceList{Collect|Free} and virshNodeDeviceList struct On 10/27/2015 11:01 AM, Pavel Hrdina wrote: > Next patch will use those function to collect NodeDevice list and find a > specific device. Make functions virshNodeDeviceListCollect() and > virshNodeDeviceListFree() together with struct virshNodeDeviceList > available to reuse existing code. > Exposing virshNodeDeviceListCollect, virshNodeDeviceListFree, and virshNodeDeviceList allows the data returned to be available to other virsh API's that may need them in the future. > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > --- > tools/virsh-nodedev.c | 16 +++++----------- > tools/virsh-nodedev.h | 11 +++++++++++ > 2 files changed, 16 insertions(+), 11 deletions(-) > OK - all that said, but your future patches don't use these functions, so is there really any use for this patch yet? It seems your 2/3 has removed what was in the 3/4 in your prior series related to calling virshNodeDeviceListCollect (and noted in your cover letter as being removed). I don't oppose the change, but it doesn't seem necessary.