Re: [libvirt] [PATCHv2] build: use gnulib passfd for simpler SCM_RIGHTS code

>>> do { >>> - ret = recvmsg(pair[0],&msg, 0); >>> + ret = recvfd(pair[0], 0); >>> } while (ret< 0&& errno == EINTR); > ret == -1 and errno == EACCES on failure to transfer fd... >

>> if (!WIFEXITED(status) || (ret = -WEXITSTATUS(status)) == >> -EACCES || >> fd == -1) { >> /* fall back to the simpler method, which works better in >> * some cases */ >> return virFileOpenAsNoFork(path, openflags, mode, uid, >> gid, flags); >> } > so this uses the fallback code, regardless of child exit status, and we > also ensured that the child got reaped. > >> What if errno == EACCES? Will we be getting all the error recovery we >> need in the caller? > Yes.

Okay. In that case, ACK.