Re: [libvirt] [PATCH 0/8] Make debugging of "cannot acquire state change lock" easier

On 03/23/2015 09:25 AM, Jiri Denemark wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=853839 > > Jiri Denemark (8): > POTFILES.in: Sort > Add support for tracking thread jobs > Force usage of virThreadCreate > virThread: Set thread job > virThreadPool: Set thread worker name > Set thread job for every RPC call > qemu: Track the API which started the current job > qemu: Add timing to domain jobs > > cfg.mk | 9 +++ > daemon/remote.c | 1 + > include/libvirt/virterror.h | 1 + > po/POTFILES.in | 5 +- > src/Makefile.am | 2 + > src/libvirt_private.syms | 11 +++- > src/locking/lock_daemon_dispatch.c | 1 + > src/nwfilter/nwfilter_learnipaddr.c | 15 ++--- > src/nwfilter/nwfilter_learnipaddr.h | 1 - > src/qemu/qemu_domain.c | 60 ++++++++++++++--- > src/qemu/qemu_domain.h | 4 ++ > src/rpc/gendispatch.pl | 6 +- > src/util/virerror.c | 1 + > src/util/virthread.c | 25 +++++-- > src/util/virthread.h | 13 ++-- > src/util/virthreadjob.c | 126 ++++++++++++++++++++++++++++++++++++ > src/util/virthreadjob.h | 33 ++++++++++ > src/util/virthreadpool.c | 44 ++++++++----- > src/util/virthreadpool.h | 14 ++-- > 19 files changed, 317 insertions(+), 55 deletions(-) > create mode 100644 src/util/virthreadjob.c > create mode 100644 src/util/virthreadjob.h > Looks fine to me... Couple of 'overall' comments... * Clean run through my Coverity checker.

* New modules add copyright for 2013-2015 - shouldn't that just be 2015

* Other modules touched haven't had their copyrights adjusted... I don't always remember either - perhaps everyone needs eblake's emacs macro to auto update when you edit a file.

ACK series