Re: [libvirt] [PATCH 2/2] qemu: migration: show disks stats for nbd migration
On Tue, Dec 20, 2016 at 10:05:50 +0300, Nikolay Shirokovskiy wrote:
There is no disks statistics when migrating with
VIR_MIGRATE_NON_SHARED_*
for qemu that supports nbd. The reason is that disks are copied via disk mirroring
and not in the scope of migration job itself. Let's enhance
qemuMigrationFetchJobStatus
to take mirror jobs into account.
Now qemuMigrationFetchJobStatus fetches both migration and nbd stats and we
need to skip fetching migration stats when migration is not running for
virDomainGetJob{Info, Stats} paths. For this purpose check_status flag
is added to qemuMigrationFetchJobStatus.
I don't think it's a good idea to misuse qemuMigrationFetchJobStatus for
fetching NBD migration statistics. Making a new function which can be
called explicitly when needed would be cleaner.
Jirka