Re: [libvirt] [PATCH] Bugfix: Check stdoutWatch before removing the handler.

Hello, On Wednesday 10 August 2011 17:25:58 Eric Blake wrote: Excellent, that fixes one anoying crash I also observed when automating my snapshot testing. While testing it I noticed the following behaviour: 1. Start virsh 2. Do "qemu-monitor-command $SOME_VM info\ chardev" to get the path of the pty used for the console → /dev/pts/Y 3. Execute "console $SOME_VM" from within the same virsh X≥2 times; terminate each console with ^]. 4. Run `lsof /dev/pts/Y' or 'lsof -p `pidof libvirtd`, which shows the pty to be opened X times. 5. Exit virsh and re-run the lsof-command: The pty is still opened. 6. Start virsh again: "0.8.4+the patch" hangs here and is not killable by SIGTERM, only SIGKILL; backtrace is attached. With 0.9.4 this seems to be fixed and is working, but: 7. Executing another "console $SOME_VM" delays for some amount of time and than opens the console. 8. Rerunning "lsof" again now shows only the pty to be opened once. Good. Can somebody else reproduce this? Is this normal? Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer hahn(a)univention.de Univention GmbH Linux for Your Business fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http://www.univention.de/