Re: [libvirt] [PATCH] xen_xs: name xendConfigVersion magic numbers
Hello Eric,
Am Donnerstag 02 Februar 2012 00:28:37 schrieben Sie:
On 01/31/2012 10:08 AM, Philipp Hahn wrote:
...
> +#define XEND_CONFIG_VERSION_3_0_2 1
> +#define XEND_CONFIG_VERSION_3_0_3 2
> +#define XEND_CONFIG_VERSION_3_0_4 3
> +#define XEND_CONFIG_VERSION_3_1_0 4
This fails 'make syntax-check' if you have cppi installed, due to
inconsistent indentation.
Looks like a new tool I have to learn about.
Also, I would have done this as an enum
rather than as #defines (it's slightly easier to debug enums in gdb).
I choose not not use an enum, because that value is read diretly from externel
XenD and can have other values. It's initialized to 0 and to -1 on errors, so
your enum is not complete.
But if your version still compiles, I'm also fine with that.
Sincerely
Philipp
--
Philipp Hahn Open Source Software Engineer hahn(a)univention.de
Univention GmbH Linux for Your Business fon: +49 421 22 232- 0
Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99
http://www.univention.de/
Attachments:
- signature.asc (application/pgp-signature — 197 bytes)