On Tue, Apr 29, 2014 at 08:04:24PM -0400, Tomoki Sekiyama wrote:
These are exposed under domfsfreeze command and domfsthaw command.
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com> --- tools/virsh-domain.c | 130 ++++++++++++++++++++++++++++++++++++++++++++++++++ tools/virsh.pod | 23 +++++++++ 2 files changed, 153 insertions(+)
+static const vshCmdOptDef opts_domfsfreeze[] = { + {.name = "domain", + .type = VSH_OT_DATA, + .flags = VSH_OFLAG_REQ, + .help = N_("domain name, id or uuid") + }, + {.name = "mountpoints", + .type = VSH_OT_DATA, + .help = N_("comma separated list of mountpoints to be frozen") + },
By using a command separated list, you prevent freezing of mount points whose directoy name contains a comma. I'd think it'd be better to just allow multiple instances of the arg eg virsh fsfreeze --mount <path1> --mount <path2> <guest>
+static const vshCmdOptDef opts_domfsthaw[] = { + {.name = "domain", + .type = VSH_OT_DATA, + .flags = VSH_OFLAG_REQ, + .help = N_("domain name, id or uuid") + }, + {.name = "mountpoints", + .type = VSH_OT_DATA, + .help = N_("comma separated list of mountpoints to be thawed") + },
Same comment here. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|