Re: [libvirt] [PATCH 03/11] conf: Remove dubious code from virDomainPCIAddressSetGrow()
On 04/04/2018 04:54 AM, Andrea Bolognani wrote:
On Tue, 2018-04-03 at 22:44 -0400, Laine Stump wrote:
> In the meantime, if I remove that code (and don't apply any of your
> patches) then a pure pcie domain *can* be successfully edited to add a
> single pci-bridge (as long as you specify an index, *and* there is an
> unused index of a smaller value), but what ends up in the
> "proper/validated" config is a pci-bridge that is plugged directly into
> a pcie-root-port (which is also wrong, but silently so).
>
> So I guess I reserve my judgement until I see what happens with your
> entire series applied, which I'll do tomorrow morning.
Looking forward to that :)
So it turns out that once all of your patches are applied, the error is
the same before or after this code is removed, so I think it may not be
executed at all.
Since it doesn't solve the issue it originally was intended to solve,
and removing it makes no functional difference, I have no problem with
you removing it (it would be nice if we could figure out a way to log a
more informative error than:
unsupported configuration: PCI controller at index 4 (0x04) has
bus='0x04',
but index must be larger than bus
but that's a separate issue.)