Re: [PATCH 13/15] storage_file_probe: Parse all qcow2 extensions at once
On a Thursday in 2025, Peter Krempa via Devel wrote:
From: Peter Krempa <pkrempa(a)redhat.com>
Refactor qcow2GetExtensions to parse everything at once and directly
assign it into fields in the parsed virStorageSource.
This removes the need for qcow2GetDataFile as it will be parsed
directly.
The patch also simplifies the juggling of variables which was needed to
parse the backing file format filed, when it was passed via pointer in
extra "filed"?
argument.
qcow2GetExtensions is now invoked on qcow2 images so we can remove the
version check for qcow(v1) images.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
src/storage_file/storage_file_probe.c | 68 +++++----------------------
1 file changed, 13 insertions(+), 55 deletions(-)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
Attachments:
- signature.asc (application/pgp-signature — 228 bytes)