Re: [libvirt] [PATCH v2] migration: add option to set target ndb server port
On Thu, Mar 17, 2016 at 16:23:25 +0300, Nikolay Shirokovskiy wrote:
On 17.03.2016 16:19, Jiri Denemark wrote:
...
> So after all your solution might probably be better, just
reformat it a
> bit:
>
> if (nbdPort)
> port = nbdPort;
> else if (virPortAllocatorAcquire(driver->migrationPorts, &port) < 0)
> goto exit_monitor;
>
> Jirka
>
I've just sent new version with a bit radical restructure as described above.
How do you evaluate it?
I think walking through the list of disks twice is the worst out of the
three options.
Jirka