Re: [libvirt] [PATCH] storage: do not clear vols before volume upload
On Fri, May 20, 2016 at 11:05:10AM -0400, John Ferlan wrote:
On 05/20/2016 05:54 AM, Ján Tomko wrote:
> Commit 5e54361c added virStoragePoolObjClearVols before refreshPool
> to prevent duplicate volume entries.
>
> However it is not needed here because we're not refreshing the pool yet,
> just checking for the existence of the refresh callback.
>
> The actual refresh is done via virStorageVolFDStreamCloseCb
> in virStorageVolPoolRefreshThread, which already calls
> virStoragePoolObjClearVols.
> ---
> src/storage/storage_driver.c | 1 -
> 1 file changed, 1 deletion(-)
>
ACK
Thanks, pushed now.
Jan