On 07/13/2012 10:00 AM, Chuck Short wrote:
Chuck: you used two different email addresses (gmail for authorship, canonical for s-o-b). Which one do you want listed in AUTHORS, or should I even alter the authorship to go by your preferred address? Once your commit is applied, 'make syntax-check' won't pass until we also update AUTHORS to match your preferred listing.
Please use the canonical.com email address.
ACK.
I've fixed the mentioned nits in my local tree, but don't want to push until I get resolution on the AUTHORS question.
I tweaked AUTHORS, re-authored the patch ('git commit --amend --author=...') to match, and pushed. Thanks for your first contribution, and looking forward to more! By the way, you can set up 'git commit' and 'git send-email' to list correct authorship, even when you develop on a machine normally tied to an alternate account, by having this in your project/.git/config (or globally at ~/.gitconfig): [user] email = preferred@address When the commit is created with the preferred authorship, then 'git send-email' will inject a 'From:' line to any message sent from a different email account, which 'git am' then honors in preference to the actual email headers. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org