Re: [libvirt] [PATCH 2/7] Don't bind mount onto a char device for /dev/ptmx in LXC

On 01/11/2012 09:33 AM, Daniel P. Berrange wrote:

From: "Daniel P. Berrange" <berrange@redhat.com>

The current setup code for LXC is bind mounting /dev/pts/ptmx ontop of a character device /dev/ptmx. This is denied by SELinux

s/ontop/on top/

policy and is just wrong. The target of a bind mount should just be a plain file

* src/lxc/lxc_container.c: Don't bind /dev/pts/ptmx onto a char device --- src/lxc/lxc_container.c | 23 ++++++++++++++--------- 1 files changed, 14 insertions(+), 9 deletions(-)

ACK. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org