On 10/01/2012 05:07 PM, Eric Blake wrote:
Commit f6430390 broke builds on RHEL 5, where glibc (2.5) is too
old to support mkostemp (2.7) or htole64 (2.9). While gnulib
has mkostemp, it still lacks htole64; and it's not worth dragging
in replacements on systems where journald is unlikely to exist
in the first place, so we just use an extra configure-time check
as our witness of whether to attempt compiling the code.
* src/util/logging.c (virLogParseOutputs): Don't attempt to
compile journald on older glibc.
* configure.ac (AC_CHECK_FUNCS_ONCE): Check for htole64.
Actually, this won't work (glad I didn't push yet); on F17 little-endian
machines, htole64 is a macro with no backing function, so you have to
use AC_CHECK_DECLS rather than AC_CHECK_FUNCS to detect it. v2 coming up.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org