Re: [libvirt] [PATCH] bhyve: fix virObjectUnlock() usage

>>> So, what you propose is checking explicitly for NULL in >>> virObjectUnlock before we do virObjectIsClass(), and if the passed >>> argument is NULL indeed, just return, without logging anything about >>> that? >> >> Yes, since we have other virObject code that special cases NULL (for >> example, virObjectUnref). > > IMHO passing NULL into the locking APIs is a coding error we shouldn't > try to paper over by ignoring. > > Ultimately I think the real flaw is the way we obtain the virDomainPtr > pointers in the first place. ie the virDomainObjListLookup functions > don't acquire a reference on the object they return. So the caller has > to worry about the object being released behind their back, hence all > our logic which has to set 'vm = NULL' in various places where it might > have been deleted. > > IOW, I'd much rather we looked at changing our design here so that we > didn't have so much NULL vm pointers in the first place. Eric, could you please comment on that?