On 06/06/2014 07:54 AM, Laine Stump wrote:
qmeuargv2xmltest.c would fail any test that logged anything during qemuParseCommandline(), but then discard the log message, even with VIR_TEST_DEBUG=2. This patch outputs the log messages with fprintf(stderr,...) when debug logging is on.
In the process of modifying that logic, the testInfo data was made more similar to that of qemuxml2argvtest.c - rather than turning info->extraFlags into a bool, an enum of flags is defined, the info struct is given an "unsigned int flags", and FLAG_EXPECT_WARNING is saved into info->flags, to be checked during the test; this will make it easier to add other FLAG_EXPECT_* items in the future. --- tests/qemuargv2xmltest.c | 45 ++++++++++++++++++++++++++++++++++----------- 1 file changed, 34 insertions(+), 11 deletions(-)
ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org