Re: [libvirt] [PATCH v5 2/4] xenconfig: add domxml conversions for xen-xl
On Thu, 26 Oct 2017 16:46:33 -0600
Jim Fehlig <jfehlig(a)suse.com> wrote:
On 10/12/2017 01:31 PM, Wim Ten Have wrote:
> From: Wim ten Have <wim.ten.have(a)oracle.com>
>
> This patch converts NUMA configurations between the Xen libxl
> configuration file format and libvirt's XML format.
...
> Xen xl.cfg domain configuration:
>
> vnuma =
[["pnode=0","size=2048","vcpus=0-1","vdistances=10,21,31,21"],
>
["pnode=1","size=2048","vcpus=2-3","vdistances=21,10,21,31"],
>
["pnode=2","size=2048","vcpus=4-5","vdistances=31,21,10,21"],
>
["pnode=3","size=2048","vcpus=6-7","vdistances=21,31,21,10"]]
>
> If there is no XML <distances> description amongst the <cell> data the
> conversion schema from xml to native will generate 10 for local and 20
> for all remote instances.
Does xl have the same behavior? E.g. with
Yes.
vnuma =
[["pnode=0","size=2048","vcpus=0-1"],
["pnode=1","size=2048","vcpus=2-3"],
["pnode=2","size=2048","vcpus=4-5"],
["pnode=3","size=2048","vcpus=6-7"]]
will distances be 10 for local and 20 for remote nodes?
Yes.
> Signed-off-by: Wim ten Have <wim.ten.have(a)oracle.com>
Other than the nits, looks good.
Will address all other brought comments under v6.
Regards,
- Wim.