Re: [libvirt PATCH v2 0/2] rST-ify and rewrite a couple of block-layer docs
On 5/10/21 6:39 PM, Kashyap Chamarthy wrote:
I don't think the Debian "sid" failure is related to my
patch:
https://gitlab.com/kashyapc/libvirt/-/pipelines/300380749/failures
Changes in v2:
- Mention backupBegin() [Peter]
- Add examples of push-mode backup using backupBegin() [Peter, Kashyap]
- Use existing rST conventions to make `rst2html5` happy [Michal]
- Update meson.build [Michal]
- Use .contents:: [Michal]
- Paragraph alignment [Michal]
Kashyap Chamarthy (2):
docs: kbase: Add a doc on live full disk backup
docs: kbase: Add a doc on merging disk image chains
docs/kbase/live_full_disk_backup.rst | 186 +++++++++++++++++++++
docs/kbase/merging_disk_image_chains.rst | 200 +++++++++++++++++++++++
docs/kbase/meson.build | 2 +
3 files changed, 388 insertions(+)
create mode 100644 docs/kbase/live_full_disk_backup.rst
create mode 100644 docs/kbase/merging_disk_image_chains.rst
Patches look good and I'm inclined to merge them. Thank you for
reworking v1 per our reviews. However, what I completely missed in my
review of v1 is to add links from docs/kbase/index.rst to new pages
you're introducing. I can fix that before push if you reply with a diff
that would do just that.
Michal