On 01/13/2011 08:45 AM, Cole Robinson wrote:
@@ -3751,6 +3753,12 @@ qemuBuildCommandLine(virConnectPtr conn, goto error;
virCommandAddArg(cmd, str); + + if (sound->model == VIR_DOMAIN_SOUND_MODEL_ICH6) { + virCommandAddArgList(cmd, + "-device", "hda-duplex", NULL);
Suppose I want a guest with two sound cards, both using model='ich6'. Am I correct that the qemu command line needs exactly one "-device hda-duplex" to enable sound from either card to get back to the host, but two "-device intel-hda,..." to implement the two cards in the guest? If so, this doesn't quite do the right thing (you instantiate the hda-duplex device twice); you'd need a bool variable set after the first time you emit this extra device. I noticed this because it is similar to my smartcard patch, where -device usb-ccid is needed only once, but -device ccid-card-* is needed per <smartcard>. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org