Re: [libvirt] [PATCH] virsh: support up to 64 migration options for command

On Thu, Mar 31, 2016 at 15:41:52 +0300, Nikolay Shirokovskiy wrote:

Upcoming compression options for migration command patch series hits current limit of 32 possible options for a command. Lets take one step further and support 64 possible options.

And all it takes is moving from 32 bit integers to 64 bit ones. The only less then trivial change i found is moving from 'ffs' to 'ffsl'.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com> --- tools/vsh.c | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-)

I think we should just rewrite the code to use virBitmap... sometime. ACK and pushed. Jirka