Re: [libvirt] [RFC] virfile: fix cast-align error
Michal Privoznik <mprivozn(a)redhat.com> [2018-10-09, 04:52PM +0200]:
What header file are you looking at? From /usr/include/bits/statfs.h:
It's s390x-specific hard-coded as an unsigned int.
> Also, I am against exposing any
> internal data types.
It's not internal if it is exposed in a public header file.
>
> virFileIsSharedFixFUSE could just return the value, the return value
> right now is not checked anyways.
Sure, but since you claim the f_type member is an unsigned type, then we
would hit the sign warning anyway.
Also, not sure. If virFileIsSharedFixFUSE() is unable to tell the
filesystem it should not touch the f_type at all.
Ok, then I guess Daniel's solution is the most simple one. I'll have
Marc send a v3 :)
--
IBM Systems
Linux on Z & Virtualization Development
--------------------------------------------------
IBM Deutschland Research & Development GmbH
Schönaicher Str. 220, 71032 Böblingen
Phone: +49 7031 16 1819
--------------------------------------------------
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
Attachments:
- signature.asc (application/pgp-signature — 902 bytes)