On Tue, Jun 30, 2009 at 10:32:45PM +0100, Daniel P. Berrange wrote:
On Tue, Jun 30, 2009 at 04:22:38PM -0400, David Allan wrote:
> * src/storage_driver.c: don't call virStoragePoolObjRemove when a pool create
call fails because the pool already exists.
> ---
> src/storage_driver.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/src/storage_driver.c b/src/storage_driver.c
> index 69dcbda..5a26993 100644
> --- a/src/storage_driver.c
> +++ b/src/storage_driver.c
> @@ -476,6 +476,8 @@ storagePoolCreate(virConnectPtr conn,
> if (pool) {
> virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR,
> "%s", _("storage pool already
exists"));
> + virStoragePoolObjUnlock(pool);
> + pool = NULL;
> goto cleanup;
> }
ACK
Indeed, a very serious bug, applied and commited !
thanks,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit
http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine
http://rpmfind.net/
http://veillard.com/ | virtualization library
http://libvirt.org/