Re: [libvirt] [PATCH] Fix connection to already running session libvirtd
Hi,
On Fri, Aug 29, 2014 at 10:22:33AM -0600, Eric Blake wrote:
Sometimes, when a patch is that invasive, I'll do it in two parts
- the
change with wrong indentation, followed by another patch that is
indentation-only. Much easier to review.
Ah right, I remember seeing that in the past, I didn't think at all
about doing that for this patch :( With 1.2.8 being so close, I'll
push v2 though instead of doing this in a v3 as I'd rather not miss the
release because of the additional round of review.
Also, are you using the patience algorithm with git? (git config
diff.algorithm patience) It makes indentation patches easier to review,
by not trying to interleave lone } and blank lines that correspond to
different code from pre- and post-patch.
I've changed that now, and the diff is indeed much better, thanks for
the tip!
Christophe
Attachments:
- attachment.sig (application/pgp-signature — 819 bytes)