Re: [libvirt] [PATCHv3 1/6] flags: use common dumpxml flags check

2011/7/15 Eric Blake <eblake(a)redhat.com&gt;: > The previous patches only cleaned up ATTRIBUTE_UNUSED flags cases; > auditing the drivers found other places where flags was being used > but not validated. In particular, domainGetXMLDesc had issues with > clients accepting a different set of flags than the common > virDomainDefFormat helper function. > > * src/conf/domain_conf.c (virDomainDefFormat): Add common flag check. > * src/storage/storage_driver.c (storageVolumeCreateXMLFrom): Pass > 0 to drivers, since all flags are currently rejected.

> > - buildret = backend->buildVolFrom(obj->conn, pool, newvol, origvol, flags); > + buildret = backend->buildVolFrom(obj->conn, pool, newvol, origvol, 0); > > storageDriverLock(driver); > virStoragePoolObjLock(pool); I don't think that this is a good idea. Even if the function doesn't have any flags at the moment this change will give us trouble when someone want's to add a flag to virStorageVolCreateXMLFrom that should have been passed down to the backend's buildVolFrom function.

ACK, to a patch without this hunk.