Re: [libvirt] [PATCH V5 01/12] src/xenxs: Export code for reuse
Kiarie Kahurani wrote:
wrap code tagged for resuse into one function and export it
Signed-off-by: Kiarie Kahurani <davidkiarie4(a)gmail.com>
---
src/xenxs/xen_xm.c | 73 +++++++++++++++++++++++++++++++-----------------------
src/xenxs/xen_xm.h | 2 ++
This patch got me thinking about the 'xenxs' directory and its
contents. IMO, the directory should be named 'xenconfig' since it
contains parsing/formating functions for the various xen config
formats. Its contents should be xen_sxpr.[ch] for sxpr format,
xen_xm.[ch] for xm format, and xen_xl.[ch] for xl format.
xen_common.[ch] would contain parsing/formating functions common to xm
and xl. Any opinions on this layout? I can work on a patch if others
think this is reasonable.
Your patch looks good, but I'll defer pushing it until hearing opinions
on the above suggestion.
Regards,
Jim