On Sun, Oct 20, 2019 at 00:45:20 -0300, jcfaracco@gmail.com wrote:
From: Julio Faracco <jcfaracco@gmail.com>
There is an issue with <resolution/> when of 'x' or 'y' settings are 0. Function virDomainVideoResolutionDefParseXML() will validate this XML, but both 'x' and 'y' will be removed. One example, if someone defines this settings:
<model ...> <resolution x='1024' y='0'/> <model/>
After applying this settings, funcion libvirt will remove both resolutions because virDomainVideoResolutionDefFormat() requires 'x' and 'y' higher than 0. So, the example above will become:
<model ...> <resolution/> <model/>
Now, libvirt only adds <resolution/> with 'x' and 'y' if boths strings are not NULL AND they are higher than 0.
Johnathon posted a more complete fix: https://www.redhat.com/archives/libvir-list/2019-October/msg01256.html